Skip to content

calendar#5444

Open
AdrJeeN wants to merge 1 commit into
mate-academy:masterfrom
AdrJeeN:develop
Open

calendar#5444
AdrJeeN wants to merge 1 commit into
mate-academy:masterfrom
AdrJeeN:develop

Conversation

@AdrJeeN

@AdrJeeN AdrJeeN commented Jun 23, 2026

Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

I am requesting changes because there are still a couple of requirement-level issues that block full acceptance. First, the task explicitly requires styles to be written in src/styles/main.scss, but your code uses src/styles/index.scss and links to styles/index.scss from src/index.html; this violates the technical constraint and needs to be fixed by moving the styles into main.scss and updating the <link> href accordingly. Second, in src/index.html the calendar element has both calendar--start-sun and calendar--start-day-sun classes, while only the calendar--start-day-* modifiers are defined in your SCSS; the extra calendar--start-sun is unused and conflicts with the specified modifier naming [CHECKLIST ITEM #1 and #3], so it should be removed.

To address these blockers: 1) create or use src/styles/main.scss, move all your current SCSS from index.scss into it, and change the HTML <link rel="stylesheet" href="styles/index.scss"> to href="styles/main.scss"; 2) in src/index.html, edit the main (calendar) tag so its class attribute becomes something like class="calendar calendar--start-day-sun calendar--month-length-31", removing calendar--start-sun. Apart from these issues, your layout, hover behavior, use of SCSS directives, and BEM structure for elements look solid and are very close to the intended solution. Once you fix the stylesheet path/name and the stray modifier class, your solution should meet all core requirements and pass the checklist.


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Important

Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.

Tip

If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.

Caution

Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.

Footnotes

  1. Rate AI review example

  2. Re-request AI review example

  3. Add AI review comments example

Comment thread src/index.html
<body>
<h1>Calendar</h1>
<main
class="calendar calendar--start-sun calendar--month-length-31 calendar--start-day-sun"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have class="calendar calendar--start-sun calendar--month-length-31 calendar--start-day-sun", but only calendar--start-day-* modifiers are defined in your SCSS and the description only mentions start-day modifier. The extra calendar--start-sun does nothing and doesn’t follow the specified modifier naming; remove it and rely on calendar--start-day-sun.

Comment thread src/styles/index.scss
$font-size: 30px;
$transirtion-duration: 0.5s;

body {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The task description requires: Write styles in src/styles/main.scss instead of src/style.css. Your HTML currently links to styles/index.scss, and the styles are in index.scss. This violates that requirement; move the styles to main.scss and update the href to point to styles/main.scss.

Comment thread src/styles/index.scss
height: 100vh;
display: flex;
justify-content: center;
align-items: center;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have class="calendar calendar--start-sun calendar--month-length-31 calendar--start-day-sun", but only calendar--start-day-sun is defined in SCSS. The extra calendar--start-sun modifier is unused and not part of the specified modifier set, which can conflict with checklist item #3 about typical BEM mistakes. Consider removing it and keep only calendar--start-day-sun (and calendar--month-length-31).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants